Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing groceries changes #923

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Storing groceries changes #923

merged 1 commit into from
Jan 6, 2025

Conversation

LeroyR
Copy link
Member

@LeroyR LeroyR commented Nov 25, 2024

Description

Storing Groceries changes to move the league forward. We want robots to start using the door handles and pick items directly from the shopping bag.
Also this incorporates pouring from the removed serving breakfast task by refilling a dry storage container.

  • Increase time limit to 7 minutes.
  • Opening door is now a main goal.
    • Additionally we close both doors to have a more realistic scenario.
  • Remove the team dependent setup (request door open, objects) instead the robot should just handle the situation.
    • Select the non heavy object if grasping is impossible for the robot
    • Requesting assistance for door opening
  • Incorporate pouring by refilling a dry storage container with cornflakes.
    • Container is placed on the table for now.
  • Grasping objects from a shopping bag
    • placed next to table.

@LeroyR LeroyR changed the title improved storing groceries Pouring in storing groceries Nov 25, 2024
@johaq
Copy link
Member

johaq commented Nov 25, 2024

I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

Copy link
Contributor

@hawkina hawkina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I like the changes and the combination.
One question: is the container for the cornflakes going to be transparent? If so, then it might add an additional difficulty for perception and we might consider rewarding it/ giving alternative options. Or just let people know in advance so that they know to train for transperency.


\scoreheading{Bonus Rewards}
\scoreitem{200}{Opening the cabinet door without human help}
\scoreitem{50}{Picking up an object from the shopping bag}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to also give 70 points here since it is more difficult. It is comparable to picking up the tiny/heavy objects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the overall scores later. For now this is just to get the different score items into the rulebook

@@ -52,9 +56,11 @@ \subsection*{Procedure}
\begin{itemize}
\item whether the cabinet door should be closed
\item whether a heavy and/or a tiny object should be used in the test
\item whether the robot plans to pour the milk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about cereal?

Copy link
Member Author

@LeroyR LeroyR Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a main goal the cereal should always be present

@hawkina
Copy link
Contributor

hawkina commented Dec 1, 2024

I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

I would vote for increasing the time limit to 7:30 mins.

@LeroyR
Copy link
Member Author

LeroyR commented Dec 2, 2024

This is just a draft to show possible integrations. Details like scoring, container (where it is placed: inside cabinet so the robot has to take it out first or on the table) and time limit need further discussion.


I like this idea since it preserves two kinds of placing challenges, placing on a table AND placing inside a shelf. My questions is should we increase the time limit for this test? Potentially 7:30 instead of 5:00.

I put it to 6:00 in the initial draft to accommodate pouring the cereals. Going up to 7:30 is also fine.

I'd also like to introduce either a bonus for the first item or a decreasing score for each additional item - f the robot stores two items it should be able to store more anyway with time being the limiting factor. The space inside the cabinet was not really limited (At least until we require storing items efficiently e.g. by stacking cans)

So my question is: Are 6 minutes not enough for a ~slow robot to get to the location, scan the shelf, pour cornflakes and store one item (add potentially opening the door as main goal). Faster robots can then store multiple objects to collect additional points.

Another open question: Do we still want this kind of opening the door?

@sunava
Copy link
Contributor

sunava commented Dec 9, 2024

Here's a rewritten version for the PR comment:

  • Johannes: Suggests adding extra time since very few teams managed to pick up all 5 objects.
  • Luis & Vanessa: Propose keeping the "storing groceries" task as it is, possibly adding time, and including the "pouring" task in Stage 2.
  • Alina: Supports the idea but prefers to focus on keeping "pouring" included due to limited available time.
  • Akinobu: Agrees with adding extra time and keeping "pouring" in Stage 2.

So, closing this for now.

@sunava sunava closed this Dec 9, 2024
@LeroyR
Copy link
Member Author

LeroyR commented Dec 10, 2024

There is still ongoing discussion in this DRAFT, i dont see rationale for closing (just rename to storing grocerie changes)

Summary until now:

  • Multiple Suggestion to add extra time, even though we have a team finishing everything in 3 minutes
  • No mention of opening door changes or using bag as bin picking
  • Meeting Discussion: Dont do Pouring here, instead combine SB with cleanup

@LeroyR LeroyR reopened this Dec 10, 2024
github-actions[bot]

This comment was marked as spam.

@LeroyR LeroyR changed the title Pouring in storing groceries Storing groceries changes Dec 10, 2024
@LeroyR LeroyR changed the title Storing groceries changes [Draft] Storing groceries changes Dec 10, 2024
github-actions[bot]

This comment was marked as spam.

@LeroyR LeroyR marked this pull request as ready for review January 6, 2025 13:59
github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

@LeroyR LeroyR changed the title [Draft] Storing groceries changes Storing groceries changes Jan 6, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ChkTeX Action

There are issues with your code. 😔 Check the annotations under the Files changed tab.

@LeroyR LeroyR merged commit 00a4974 into master Jan 6, 2025
8 checks passed
@LeroyR LeroyR deleted the improved_sg branch January 6, 2025 15:01
@LeroyR LeroyR restored the improved_sg branch January 6, 2025 15:02
@SparkRibeiro21
Copy link
Contributor

I think the storing milk and cornflakes into the containers is a great idea. The way it is now with the recent changes in rulebook, there is NOTHING the robots have to do with the objects that is not just pick and place (there is no action the robots have to do with an objects, like wiping, pouring, watering plants, placing food in plate ...), and that feels very wrong for a competition for domenstic service robots.

I also really like the addition of the objects inside the bag.

Regarding the cabinet door opening (as discussed in the TC meeting of 06/01/20205), is it natural to have one cabinet door open and the other one closed? I dont think this is a realistic scenario... we should add handles to the doors and have them both closed, that is a realistic scenario. (cheap handles cost ~2€)

Time limit should be at least 7:00 to allow time for teams to also perform the new updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants